Repository navigation
[DeadCode] Skip static/$this union @return in RemoveUselessUnionReturnDocblockRector - #8649
Merged
Merged
Conversation
…nDocblockRector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
staticand$thisdenote the runtime subclass, which a native return type like?SomeInterfacecannot express. Removing such a@return static|nulldocblock loses information, so it must be kept.Reported on a Mautic trait:
When
staticcannot resolve to a concrete class (e.g. a trait or free function in the analyzed reflection scope), it degrades tomixed, which is broader than the native type and the rule wrongly stripped the docblock.Fix: skip the union
@returnwhen it containsstaticor$this. Added skip fixtures for both the trait and the degraded (free-function) case.