Repository navigation
[perf] Skip NestedAnnotationToAttributeRector for nodes without a docblock - #8628
Merged
TomasVotruba merged 2 commits intoOct 11, 2026
Merged
Conversation
…block The rule subscribes to Property, Class_ and Param and built a PhpDocInfo for every node. The attribute groups come only from docblock doctrine annotations and it reprints an existing docblock, so a node without one always returns null. Guard the phpdoc path behind getDocComment(). Behaviour unchanged.
TomasVotruba
force-pushed
the
perf-nested-annotation-to-attribute-skip-nondoc
branch
from
October 11, 2026 16:56
db26b43 to
e2270d7
Compare
TomasVotruba
deleted the
perf-nested-annotation-to-attribute-skip-nondoc
branch
October 11, 2026 17:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the RenameClassRector phpdoc-guard optimization.
NestedAnnotationToAttributeRectorsubscribes toProperty,Class_andParamand built aPhpDocInfofor every visited node. Its attribute groups come only from docblock doctrine annotations, and it reprints an existing docblock rather than adding one, so a node without a docblock always ends inreturn null.Guard the phpdoc path behind
getDocComment() !== null. Behaviour identical.Tests:
rules-tests/Php80/Rector/Property/NestedAnnotationToAttributeRector(10) green, ECS + PHPStan level 8 clean.