Repository navigation
[perf] Skip AnnotationToAttributeRector for nodes without a docblock - #8627
Merged
Merged
Conversation
The rule subscribes to eight node types (Class_, Property, Param, ClassMethod, Function_, Closure, ArrowFunction, Interface_) and built a PhpDocInfo for every one. The attributes it produces come only from docblock annotations, and it reprints an existing docblock rather than adding a new one, so a node without a docblock always returns null. Guard the phpdoc path behind getDocComment() after the configuration check. Behaviour unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the RenameClassRector phpdoc-guard optimization.
AnnotationToAttributeRectorsubscribes to eight node types (Class_,Property,Param,ClassMethod,Function_,Closure,ArrowFunction,Interface_) and built aPhpDocInfofor every visited node. The attribute groups it produces come only from docblock annotations, and it reprints an existing docblock - it never adds one to a doc-less node - so a node without a docblock always ends inreturn null.Guard the phpdoc path behind
getDocComment() !== null, placed after the existing configuration check so that behaviour is preserved.Tests:
rules-tests/Php80/Rector/Class_/AnnotationToAttributeRector(65) green, ECS + PHPStan level 8 clean.