Repository navigation
[perf] Skip RemoveNullTagValueNodeRector for nodes without a docblock - #8625
Merged
Merged
Conversation
The rule subscribes to ClassMethod, Function_, Expression and Property and built a PhpDocInfo for every node to look for null param/return/var tags. Those tags only exist inside a docblock, so guard all branches with a single getDocComment() check. Each branch already no-ops when the tag is absent, so behaviour is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the RenameClassRector phpdoc-guard optimization.
RemoveNullTagValueNodeRectorsubscribes toClassMethod,Function_,ExpressionandProperty, building aPhpDocInfofor every visited node to strip null@param/@return/@vartags. Those tags only exist in a docblock, so a single top-levelgetDocComment() !== nullguard covers all four branches. Every branch already no-ops when the tag is absent, so behaviour is identical.Tests:
rules-tests/DeadCode/Rector/ClassMethod/RemoveNullTagValueNodeRector(6) green, ECS + PHPStan level 8 clean.