Repository navigation
[CodeQuality] Deprecate SwitchTrueToMatchRector - #8622
Merged
Merged
Conversation
… (true) construction, needs human check
TomasVotruba
force-pushed
the
tv-deprecate-switch-true-to-match
branch
from
October 11, 2026 10:04
a4e6a8c to
028509c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate
SwitchTrueToMatchRector.Both
switch (true)andmatch (true)are hacky constructions - swapping one for the other does not improve the code. A constant list or explicit mapping is clearer, and the change needs a human check rather than an automated rewrite.Follows the same pattern as the recent
InnerFunctionToPrivateMethodRectorandMoveInnerFunctionToTopLevelRectordeprecations:ShouldNotHappenException, marked@deprecated+DeprecatedInterfaceCodeQualityLevel