Repository navigation
[CodeQuality] Skip anonymous class in AssertEmptyNullableObjectToAssertInstanceofRector - #792
Merged
Merged
Conversation
…rtInstanceofRector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9922
AssertEmptyNullableObjectToAssertInstanceofRectorrewroteassertNotNull()on a nullable anonymous class intoassertInstanceOf()using PHPStan's internalAnonymousClass<hash>name. That class does not exist at runtime, so the rewritten test errors withUnknownClassOrInterfaceException.Now the rule skips when the non-null type is an anonymous class - there is no writable class name to emit, so
assertNotNull()is left untouched.