Skip to content

[lists] strictly parse list type queries #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tyl-droid wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[lists] strictly parse list type queries #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/lists/src/lists.app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,7 +773,8 @@ const app = new Hono<App>()
// Echoed, but only when it fits the byte the client reads it back into — anything
// outside 0–255 can't round-trip, so a nonsense `?type=` gets the default instead of a
// number that would break the response on the way in.
const type = Number.parseInt(c.req.query('type') ?? '', 10)
const rawType = (c.req.query('type') ?? '').trim()
const type = /^-?\d+$/.test(rawType) ? Number(rawType) : Number.NaN
const echoed =
type >= 0 && type <= MAX_LIST_ENTITY_TYPE ? type : DEFAULT_ALGORITHMIC_LIST_TYPE

Expand Down
Loading