Onboarding is one ticket implemented by the onboard assembly line, opening one PR - #2083
Conversation
|
Lore is reviewing this PR — f432eb76-923e-44ea-b854-059432a08bcc. Reply to any review comment to discuss or approve a fix (e.g. "ok, fix it"). Comment |
Lore Spec ImpactLore API unreachable (HTTP 504). This check could not run. |
|
Lore code-review run failed (iteration_max — AssemblyLine code-review: node "review" failed: the review reached changes_requested but nothing was posted to the PR — its findings block did not parse, so the findings are lost — Unrecognized failure — see the Event Timeline metadata and agent pod logs. — the review->review retry budget (1) is spent) — f432eb76-923e-44ea-b854-059432a08bcc. Comment |
|
@lore review |
26c3771 to
1ce84ca
Compare
|
Lore is reviewing this PR — c4411309-d5be-4e59-ad55-a35a09ec555b. Reply to any review comment to discuss or approve a fix (e.g. "ok, fix it"). Comment |
![lore-agent[bot]](https://avatars.githubusercontent.com/u/141229953?s=60&v=4){kind=small}
There was a problem hiding this comment.
Lore review — Approved
Latest changes correctly implement recording the onboarding PR URL and update specs accordingly.
Must fix (0) · Consider (0) · Nits (0)
Reviewed by gemini-3.1-flash-lite
Reply to any review comment to discuss or approve a fix (e.g. "ok, fix it"). Comment @lore review to re-run the review.
There was a problem hiding this comment.
Lore review — Approved
Onboarding PR recording logic successfully implemented and documented per conventions.
Must fix (0) · Consider (0) · Nits (0)
Reviewed by gemini-3.1-flash-lite
Reply to any review comment to discuss or approve a fix (e.g. "ok, fix it"). Comment @lore review to re-run the review.
There was a problem hiding this comment.
Lore review — Approved
Replaces in-process onboarding with the onboard assembly line to guarantee a single PR
Must fix (0) · Consider (0) · Nits (0)
Reviewed by gemini-3-flash-preview
Reply to any review comment to discuss or approve a fix (e.g. "ok, fix it"). Comment @lore review to re-run the review.
f9a8555 to
6c00121
Compare
|
@lore review |
|
Lore is reviewing this PR — ccc1bbdb-23b8-45a2-878c-5b7a92f65e1f. Reply to any review comment to discuss or approve a fix (e.g. "ok, fix it"). Comment |
There was a problem hiding this comment.
Lore review — Approved
The new commits correctly implement the repository onboarding workflow, consolidate onboarding content, and address prior spec-link and linting concerns.
Must fix (0) · Consider (0) · Nits (0)
Reviewed by gemini-3.1-flash-lite
Reply to any review comment to discuss or approve a fix (e.g. "ok, fix it"). Comment @lore review to re-run the review.
There was a problem hiding this comment.
Lore review — Approved
Onboarding architectural shift successfully implements the assembly line pattern.
Must fix (0) · Consider (0) · Nits (0)
Reviewed by gemini-3.1-flash-lite
Reply to any review comment to discuss or approve a fix (e.g. "ok, fix it"). Comment @lore review to re-run the review.
There was a problem hiding this comment.
Lore review — Approved
Replaces the single onboarding agent with an onboarding assembly line, securely handling deterministic setup updates and PR lifecycle hooks.
Must fix (0) · Consider (0) · Nits (1)
Reviewed by gemini-3-flash-preview
Reply to any review comment to discuss or approve a fix (e.g. "ok, fix it"). Comment @lore review to re-run the review.
|
@lore review |
173bff6 to
fcf7ce2
Compare
|
Lore is reviewing this PR — fb873685-d5ff-4566-8331-1ead7d5a7e29. Reply to any review comment to discuss or approve a fix (e.g. "ok, fix it"). Comment |
There was a problem hiding this comment.
Lore review — Approved
Refactored onboarding to an assembly line workflow; seems consistent with Lore architecture.
Must fix (0) · Consider (0) · Nits (0)
Reviewed by gemini-3.1-flash-lite
Reply to any review comment to discuss or approve a fix (e.g. "ok, fix it"). Comment @lore review to re-run the review.
There was a problem hiding this comment.
Lore review — Approved
Migrates onboarding to a standard assembly line with robust lifecycle handling.
Must fix (0) · Consider (1) · Nits (0)
Reviewed by gemini-3-flash-preview
Reply to any review comment to discuss or approve a fix (e.g. "ok, fix it"). Comment @lore review to re-run the review.
|
@lore review |
|
Lore is reviewing this PR — 0959e881-440f-4f9d-a598-423a68ee92e3. Reply to any review comment to discuss or approve a fix (e.g. "ok, fix it"). Comment |
There was a problem hiding this comment.
Lore review — Approved
Latest commits correctly implement the single-button enrolment box with idempotent re-anchor and state-aware trigger.
Must fix (0) · Consider (0) · Nits (0)
Reviewed by gemini-3.1-flash-lite
Reply to any review comment to discuss or approve a fix (e.g. "ok, fix it"). Comment @lore review to re-run the review.
There was a problem hiding this comment.
Lore review — Approved
Latest commits correctly implement the single-button enrolment box with idempotent re-anchor and state-aware trigger.
Must fix (0) · Consider (0) · Nits (0)
Reviewed by gemini-3.1-flash-lite
Reply to any review comment to discuss or approve a fix (e.g. "ok, fix it"). Comment @lore review to re-run the review.
|
@lore review |
There was a problem hiding this comment.
Lore review — Approved
Onboarding process transitioned successfully to an assembly line architecture; code changes adhere to project conventions.
Must fix (0) · Consider (0) · Nits (0)
Reviewed by gemini-3.1-flash-lite
Reply to any review comment to discuss or approve a fix (e.g. "ok, fix it"). Comment @lore review to re-run the review.
There was a problem hiding this comment.
Lore review — Approved
Solid refactoring that successfully migrates repo onboarding to the dark factory assembly line.
Must fix (0) · Consider (0) · Nits (0)
Reviewed by gemini-3-flash-preview
Reply to any review comment to discuss or approve a fix (e.g. "ok, fix it"). Comment @lore review to re-run the review.
… onboard line implements Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…rewriting the seeded org prompt Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…the ticket to the onboard line Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…s the ticket body; the dashboard offers no fix PR mid-onboarding; specs amended Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… export, fix two mis-anchored spec links Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…uirements in one PR, or none when it is already current The Floor commits a Lore-owned file only when it differs from canonical and a repo-owned one only when absent; a re-onboard carries the update ticket; an onboard line whose push delivered nothing completes instead of erroring; the enrollment section gains a standing Update Lore setup trigger. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…egenerated Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…e and refuses to guess by ordinal when counts differ One link added, removed or relabelled used to hand every later line-number-labelled link its neighbour's anchor; CI's format job then committed the damage and lint went red. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…e state-aware trigger; the ticket follows the repo's state, not the reonboard flag Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… of their own, and the re-anchor script keeps labels as written so it is idempotent A button per missing file read as one PR per file when each queued the same run. The script rewrote a label to its new line, which collided with another link's base label, so two links swapped on every run. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…ared-utilities spec stops crediting the deleted onboardTaskDescription Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
1d2d135 to
722de11
Compare
|
@lore review |
|
Lore is reviewing this PR — 4c819396-3a37-4bbf-ba73-3b984a76399d. Reply to any review comment to discuss or approve a fix (e.g. "ok, fix it"). Comment |
There was a problem hiding this comment.
Lore review — Approved
The latest commits primarily consist of cleanup, minor refinements, and re-renumbering of a migration. No new significant issues were introduced.
Must fix (0) · Consider (0) · Nits (0)
Reviewed by gemini-3.1-flash-lite
Reply to any review comment to discuss or approve a fix (e.g. "ok, fix it"). Comment @lore review to re-run the review.
1 participant
Why
One onboarding could leave three pull requests open on the target repo: the onboarding scaffold PR, the dashboard's fix-ingest PR, and the fix-trace-impact PR (the dashboard read the repo as "missing" its workflows while they sat on the unmerged onboarding branch). A post-merge "initial ingestion" task existed too, with no caller. The in-process handler also drafted every file with one LLM call from a top-level-only tree, which is the root of #1201.
What Changed
onboard(guard, trust ladder and UI redirect unchanged). The task description is now the onboarding ticket (onboardTicketBody): every file owed, the prompt it is written from, and the rules. It becomes the task's GitHub Issue.handleOnboardseeds labels, sets the ingest variable and secret, creates the branch off the real default branch, and commits the verbatim scaffolding (both workflows always, each static template whose exact path is absent). It then dispatches the newonboardassembly line, which has the implementation line's shape with theonboardrecipe on its implement node. The line's push node opens the PR.stampLinePrrecords an onboard line's PR aslore.repos.onboarding_pr_url, so thepr-openblock and the merge-check station keep working.checkOnboardingPRs, the initial-ingestion task, the lore-apifetchRepoContext, and the Floor's per-file LLM planner and committer are deleted. Ingestion after merge is the merged workflows' own push run.reonboardreach the same run: theonboardline fed an update ticket. The Floor commits a Lore-owned file (both workflows, the threelore-*.ymlissue templates) only when it differs from canonical, and a repo-owned one (.claude/settings.json,ISSUE_TEMPLATE/config.yml) only when absent. The agent adds newly required files and realigns onlylore-tests.ymlandpr-description-check.yml. It opens one PR, or none: an onboard line whose push delivered nothing completes as "already current" instead of erroring.onboardrecipe is a claude-code recipe fed by the ticket. Migration0084rewrites the org row seeded by0054, only while it still carries the old JSON-output prompt. The catalog seed is regenerated.Alternatives Considered
implementationtask from the ticket. Refused by the trust ladder on docs-tier repos, and the guard keys ontask_type = 'onboard'.implementation-loopline. Its definition-of-done node writes red acceptance tests, which a scaffolding ticket on an empty repo cannot express.ADRs & Architecture
Amends
specs/4-ux-repo-onboarding(scenario 2, FR-2, FR-5),specs/api-routes/onboard,specs/mcp-tools/onboard-repo,specs/6-dark-factoryFR6.8 and FR6.16,specs/project-test-interface11 and 12, and CLAUDE.md. No new ADR: the routing rule follows ADR-028 and ADR-031.Testing
Floor 1275, shared work 731, assembly-lines 296, web-ui 2647, lore-api onboarding 18, all passing.
tsc --noEmitis clean on floor, lore-api, shared and web-ui. ESLint is clean on every changed file. The catalog drift check passes. Not exercised: a live onboarding on a cluster.🤖 Generated with Claude Code