Conversation
…ling - Centralized body size limits in shared constants for consistency across services. - Updated agent-events, server, and lore-api to use new body limit constants. - Introduced required environment variable functions to enforce deployment configurations. - Enhanced database connection handling to ensure required parameters are supplied. - Added tests for new enforce functions and improved error handling for missing environment variables. - Specified default drain timeout for event processing across services. - Implemented collaborative feature planning specification to enhance team input during feature drafting.
|
Lore is reviewing this PR — ca44a532-72a2-4875-bf13-e0ef018d6017. Reply to any review comment to discuss or approve a fix (e.g. "ok, fix it"). Comment |
Lore Spec ImpactLore API unreachable (HTTP 504). This check could not run. |
![lore-agent[bot]](https://avatars.githubusercontent.com/u/141229953?s=60&v=4){kind=small}
There was a problem hiding this comment.
Lore review — Changes suggested
Fix port bounds validation, clean up leftover PR review notes, and remove noisy heartbeat logs.
Must fix (1) · Consider (2) · Nits (1)
Reviewed by gemini-3-flash-preview
Reply to any review comment to discuss or approve a fix (e.g. "ok, fix it"). Comment @lore review to re-run the review.
requiredPort reads the whole value and refuses anything outside 1..65535; enforceIntegerInterval takes its bounds as one IntegerInterval. The heartbeat loop no longer logs every successful beat, and cluster routes spread NO_HAPI_AUTH. The three review todos are resolved in code: git_credential stays (the agent image exchanges it at the credential broker), the file identity store is gone (every cluster-agent, a laptop's included, keeps its identity in a Secret), and cluster-agent now lints against inline object parameter types, using CrdPair, Page/PageRequest and NamespacedName. Spec and ADR links follow the moved cluster route tests, new tests are linked, over-long comments are cut to one line, and mcp-server reads its port in the transport layer. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Lore review — Approved
Fast re-check of PR #2082: new commits address prior review comments and handle refactors for body size limits and environment variable handling appropriately.
Must fix (0) · Consider (0) · Nits (0)
Reviewed by gemini-3.1-flash-lite
Reply to any review comment to discuss or approve a fix (e.g. "ok, fix it"). Comment @lore review to re-run the review.
…oor pool test its DB config Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Lore review — Approved
Re-check completed: changes appear compliant with repo conventions and linting; modularization of routes in cluster-agent is clean.
Must fix (0) · Consider (0) · Nits (0)
Reviewed by gemini-3.1-flash-lite
Reply to any review comment to discuss or approve a fix (e.g. "ok, fix it"). Comment @lore review to re-run the review.
1 participant
Every service now fails fast at startup when a required environment variable or database parameter is missing, instead of booting half-configured.
requiredEnvand new enforce helpers inlibs/shareddo the checking, andpg-poolrefuses a connection with missing parameters. Request body limits and the event drain timeout now come from shared constants, so the Floor, lore-api, the event-router and cluster-agent can no longer disagree about them.cluster-agent's 235-line
routes/cluster.tsis split into one file per endpoint underroutes/cluster/(agents, jobs, pods, pod listing, per-task tokens, restart), with the shared dependencies incluster-route-deps.ts. The heartbeat loop and registrant were tidied along the way.The branch also adds the
collaborative-feature-planningspec.🤖 Generated with Claude Code