Skip to content

Storybook duo-theme preview adds accessibility violations #80

Description

@t-schemmer

Storybook's preview contains blocks to show both themes (light and dark) at the same time. If a developer creates a component with an IDREF, they will be duplicated, which the accessibility-plugin will detect as a violation.

Thoughts

  • Create a theme toggle plugin (on a Storybook Panel)
  • Use an existing plugin to toggle the theme
  • Create a toggle as a knob

Notes

  • Sometimes it necessary to implement static or dynamic IDREF's for Accessibility purposes (e.g. using aria-labelledby or aria-describedby). Even generated IDREF's within the component can still contribute to issue described above.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    a11yAccessibility concerns or requestskit: StorybookConcerning Storybookstatus: needs triageThese issues haven't been looked at yet by a maintainer.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions