Repository navigation
Simplify execution typing fixes to local casts - #1024
Merged
Merged
Conversation
tobiasraabe
marked this pull request as ready for review
October 12, 2026 04:58
tobiasraabe
enabled auto-merge
October 12, 2026 05:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ty 0.0.83 update in #1008 introduced task-specific tree helpers and runtime protocol validation to address recursive leaf inference in execution. Replace those helpers with two local casts on the existing
tree_leavescalls:list[TaskNode]when saving return products andlist[PNode]after provisional products are collected.Remove the internal and public
task_iomodules and their helper-specific tests. This restores the earlier execution behavior, including removal of the added teardown protocol checks, while retaining the ty dependency update. Comments explain the node invariants at each cast.Validation:
just lintpassed.just typingpassed with ty 0.0.83.uv run --locked --group test pytest tests/test_execute.py tests/test_provisional.py tests/test_tree_util.py -q: 88 passed, covering nested return products, provisional products, and missing-product errors.