Repository navigation
Conversation
…he tree Directory symlinks and their targets share an inode, so _UniqueDirs collapsed them and walk order decided which path landed in the file list. Skip in-tree directory symlinks so the original path is kept.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_UniqueDirskeysos.walk(..., followlinks=True)entries on(st_dev, st_ino). A directory and a symlink to it therefore collapse to one path, and whichever name is visited first is the one that appears in the file list. Creating the symlink after the directory can makefoo/adisappear and leave the contents underfoo/b.Skip directory symlinks whose target is already inside the walk root so the original path is kept. A symlink that points outside the tree is still followed.
This is the distutils-side fix for pypa/setuptools#4937 (redirected from pypa/setuptools#5324).
Tests:
pytest distutils/tests/test_filelist.py— 13 passed, 4 skipped (Windows host without symlink privilege; mocked walk-order cases pass)