Conversation
mats-knmi
force-pushed
the
xarray/main
branch
from
September 2, 2024 12:52
666a044 to
2e0aca2
Compare
* make dimension.py xarray compatible * convert final method in the dimension module * nanmin in stead of zerovalue in square domain method * make test steps skill run * undo accidental change * remove commented out code * The dataset can contain more than one dataarray * Address pull request comments * Add links to dataset documentation everywhere
* make test steps skill run * undo accidental change * make steps nowcast xarray compatible * wrap all nowcasts in xarray * fix dimension.py tests * update dimension.py to work with new dataarrays * fix test_nowcast_utils tests * update docs and make xarray usage more explicit in nowcasts * update docs and make xarray usage in motion methods more explicit
mats-knmi
force-pushed
the
xarray/main
branch
from
September 23, 2024 13:38
095e046 to
c2ae9db
Compare
… and found some first declartions in the code that where not in the init
…recast runs in a row
Co-authored-by: mats-knmi <145579783+mats-knmi@users.noreply.github.com>
… into xarray/main
* Fix more tests and make steps nowcast work again * fix test_motion.py
* Add comments about pixelsize * Move comment up slightly * Add clarification * Update test_io_mch_gif.py * Update test_io_mch_gif.py
* converted minutes to seconds for timestep for call to io.read_timeseries in get_precipitation_fields * linted * fixed test_datasets by adding timestep in helper function load_dataset in datasets.py
* On the way to all tests passing in the pysteps 2.0 project. Now working on FMI io tests * Nearly all IO tests pass now, only FMI_geotiff is acting strangly
* fix test_importer_decorator * fixed some more tests * remove test.nc
… does not set metadata correctly (#515)
* All specific IO tests are done * Fixed last IO test?
…h xarray (#517) * removed failing plugin test due to cookiecutter not implemented correctly with xarray * linted
* fix blend utils and xarray dataformat * fix test blending utils * fix steps blending tests
* fix blend utils and xarray dataformat * fix test blending utils * fix steps blending tests * fix loose ends and make all relevant tests succeed * fix donothing * Add forecast reference time and drop velocity in output dataset * fix grid_mapping_name * extrapolate from last value not first
* changed numpy to xarray * changed string access of precip_var to use attrs defined variable * add deleted line * Linted --------- Co-authored-by: Lars Bonnefoy <lars.bonnefoy@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the draft pull request that will collect all the changes that need to be made to fully integrate xarray into pysteps.
Progress of this project is tracked here.
THIS PULL REQUEST CAN ONLY BE MERGED AS PART OF THE VERSION 2.0 PYSTEPS RELEASE.