Skip to content

test: isolate utility queue transactions in CI - #155

Merged
DeusExTaco merged 1 commit into
developfrom
feature/utility-queue-test-isolation
Sep 19, 2026
Merged

DeusExTaco merged 1 commit into
developfrom
feature/utility-queue-test-isolation

Conversation

@DeusExTaco

Copy link
Copy Markdown
Contributor

Summary

  • Give utility queue integration tests a per-test file-backed SQLite database so dispatch writers and cancellation readers use independent connections, matching production.
  • Commit test setup before dispatch rather than relying on uncommitted data leaking across sessions.
  • Add a deterministic regression proving that closing a status reader cannot roll back a pending writer update.

Why

The exact-commit develop gate exposed timing-dependent lost updates in three queue tests after #154. The old shared in-memory connection allowed one session to roll back another session's writes. The new regression fails under that fixture and passes with independent connections.

Validation

  • All 94 queue and cancellation tests pass, with all original result/history assertions retained.
  • Ruff lint and formatting pass.
  • A fresh make ci-full is running for this follow-up; the application code already passed the complete local gate and PR fix: harden import recovery and utility cancellation #154 checks.

Scope

Test-only change. No runtime behavior, safety checks, coverage thresholds, or production files changed. Edge publication remains held until the merged commit passes all release gates.

Use a file-backed SQLite fixture and commit setup before dispatch. The shared in-memory connection let cancellation readers roll back pending result writes, producing timing-dependent failures. Retain all existing outcome assertions and add a deterministic transaction-isolation regression.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 19, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-19T03:03:25.907257Z b607b0c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@DeusExTaco DeusExTaco added the ci:full Run the full CircleCI PR gate label Sep 19, 2026
@DeusExTaco

Copy link
Copy Markdown
Contributor Author

The fresh make ci-full run passed completely: 12,023 application tests at 91.16% coverage, 25 accessibility tests, 575 browser tests in each browser, and all 7 production-image smoke tests. The GitHub Python 3.12, 3.13, and 3.14 jobs also passed with the isolated fixture. No runtime changes or weakened assertions were needed.

@DeusExTaco
DeusExTaco merged commit d965657 into develop Sep 19, 2026
52 of 56 checks passed
@DeusExTaco
DeusExTaco deleted the feature/utility-queue-test-isolation branch September 19, 2026 03:20
@DeusExTaco

Copy link
Copy Markdown
Contributor Author

Merged and included in the successful edge publication: https://github.com/pullboxapp/pullbox/actions/runs/35419313435 . The final develop commit d965657 passed the Python 3.12/3.13/3.14 matrix and all required release gates. Version 1.3.1-dev is verified on both platforms and both registries; production latest was not changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:full Run the full CircleCI PR gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant