Skip to content

feat(import): simplify review and strengthen reconciliation - #151

Merged
DeusExTaco merged 12 commits into
developfrom
feature/import-review-workspace
Sep 17, 2026
Merged

DeusExTaco merged 12 commits into
developfrom
feature/import-review-workspace

Conversation

@DeusExTaco

@DeusExTaco DeusExTaco commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replace the crowded Step 3 screen with focused review lanes and scoped series/file decisions while preserving import execution and completed-job Follow-up.
  • Improve stale Mylar reference reconciliation, scan-count clarity, conflicting-copy review, one-page archive previews, and exact lettered issue identities.
  • Add an explicit background series-folder rescan for new or missed files, with safe registration and unresolved items routed to import review.
  • Preserve the detected archive format during registration and repair, and support rescan queries on both SQLite and PostgreSQL.
  • Require canonical numeric ComicVine resource IDs before constructing detail-request paths.

Validation

  • The preceding branch checkpoint passed local make ci-full: 11,478 main tests, 91.07% coverage, 575 browser tests per browser, 25 accessibility checks, and 7 production-container smoke tests.
  • Review fixes: 140 focused rescan, registration, archive-signature, and reader tests passed; Ruff and strict mypy passed. Regression tests first reproduced both reported defects.
  • Actual PostgreSQL execution verified job isolation, JSON outcome counts, failed/null outcomes, and paged rescan reports. SQLite execution is covered by the regression suite.
  • Real-file acceptance: selected one comic, deferred another, verified persistence across reload, completed the import, opened the recovery modal, and recovered the deferred comic through the same background endpoint used by Save recovery choices. Both issues are owned, both source hashes are unchanged, and the resolved row disappears from Follow-up.
  • Two existing browser checks were skipped for unavailable fixture states. This targeted acceptance check does not claim exhaustive manual coverage of every button combination.
  • Full GitHub CI, security, CodeQL, workflow hygiene, and production Docker validation passed on final PR commit 74348b4 before merge. Both review findings are resolved.
  • Final follow-up: 122 focused provider/assignment tests passed, including 14 new malformed-ID cases. Both full browser suites passed again (575 each, 2 skipped each); history coverage now asserts both sort directions independently of other tests' source paths.

Release Notes

  • Intended for the next edge build, not a stable-version release.
  • Includes the series-rescan job-type migration; take a normal database backup before upgrading.
  • Source preservation, exact issue ownership, archive safety, partial imports, retries, and completed-import recovery remain enforced.
  • No security exceptions or runner access permissions were changed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-17T02:36:43.350233Z 6ea5d05 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6ea5d056fb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/pullbox/api/v1/series_rescan.py Outdated
Comment thread src/pullbox/core/archive.py
@DeusExTaco DeusExTaco added the ci:full Run the full CircleCI PR gate label Sep 17, 2026
@DeusExTaco
DeusExTaco merged commit 3bf28b7 into develop Sep 17, 2026
30 checks passed
@DeusExTaco
DeusExTaco deleted the feature/import-review-workspace branch September 17, 2026 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:full Run the full CircleCI PR gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant