Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (8)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Repository: pubnub/javascript/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Thank you for your effors to create this PR, Let us give some to to review the same. |
|
@thilllon Due to our repository setup and deployment process, we aren't able to merge PRs directly from external branches.To follow our release workflow while ensuring your contribution is properly recognized, I’ve ported your changes over to PR #518 (with some very minor tweak) to process them through our pipeline. We’ve kept your commit authorship intact so your contribution is fully visible in git history and changelog. Thanks again for helping improve the library! |
|
@mohitpubnub Thanks! |
PubNub 13.0.1's published declaration bundle fails a strict consumer typecheck with
skipLibCheck: false:setProxy()references an undeclaredNodeTransportProxyConfiguration, andSubscriptionResponsereferences an undeclaredDataSyncEvent.The source compiler succeeds because both types exist before declaration generation. The aggregator omits the entire internal Node transport module containing the proxy configuration, while
stripInternalremovesDataSyncEventeven though the public response union needs it.PubNub.NodeTransportProxyConfiguration.DataSyncEventin declarations, matching the other response variants; its internal fingerprint field remains stripped.strict: trueandskipLibCheck: false.@types/nodedevelopment dependency directly so the regression check does not rely on transitive npm hoisting.No runtime behavior or proxy configuration shape changes.
Validation:
types-aggregate.tspipeline pass. Local pnpm installation used the imported committed npm lockfile; the source compiler was invoked with--types nodeto avoid the repository's unrelated empty@types/expectstub..ctsand.mtsconsumers pass under TypeScript 5.8.2 and 7.0.2, including valid/invalid proxy arguments and DataSync event narrowing.git diff --checkpass.Discovered while validating the SDK directly for thilllon/nestjs-kit#505; the reproduction does not depend on NestJS.