chore: ignore .env so a local token cannot be staged - #39
Open
sergebulaev wants to merge 1 commit into
Open
sergebulaev wants to merge 1 commit into
sergebulaev wants to merge 1 commit into
Conversation
A .env in a working copy of this repo holds somebody's own tooling credentials - there is no application code here that would read one. It was not ignored, so `git add -A` stages it, and GitHub push protection has already had to stop a GitHub PAT in one from reaching a branch. Push protection caught it, which is the good outcome. This makes the earlier step impossible instead of relying on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.envis not in.gitignorehere, sogit add -Astages it.There is no application code in this repo that reads a
.env, so one in a working copy is somebody's own tooling credentials. GitHub push protection has already had to stop a GitHub PAT in one from reaching a branch during work on #25 today — it caught it, nothing reached the remote, and that is the good outcome. This makes the earlier step impossible rather than relying on the later one..env.examplestays allowed, in case one is ever wanted.