Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Treat a mounted native save container with zero files as
SAVEDATA_NO_SAVE_DATAand remove its staged archive instead of uploading it.Why
A title can have a mountable Horizon save container before the game has written any files.
ZipWriterstill creates a technically valid 22-byte empty ZIP, and the previous code returned success because it only checked whether individualadd()calls failed. With no files, no call fails.That empty ZIP is non-zero-length, so transport-level empty-body checks cannot identify it. Once committed, it becomes the latest revision and restore validation must reject it.
Implementation
saves/;SAVEDATA_NO_SAVE_DATAresult;Validation
Both the app and sysmodule build successfully from a clean client build. The issue was reproduced on hardware with a never-played installed title: every generated archive was exactly 22 bytes with zero ZIP entries.