Refuse to splice a channel without option_unified_sigs - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A splice co-signs the previous funding output with the channel's hash type. On a channel without
option_unified_sigs, such as any opened withv26.06.7-blake2b.1to.3, that carries it into a new funding output that is also valid for a node that has not upgraded.splice_initrefuses such a channel.channeldrefuses a peer'sspliceon one with a warning, as it does for an out-of-range feerate.--dev-splice-without-unified-sigsskips our own check so the peer's refusal can be tested.doc/blake2b-upgrade.md§4 said the opt-in was added "whenever both peers support it". New channels already require it from both sides; the text now says so, and tells operators to close and reopen older channels.Tests in
tests/test_unified_robustness.py:test_new_channel_requires_unified_sigs: a node withoutoption_unified_sigscan neither open a channel to an upgraded node nor accept one, over v1 and v2 opens.test_no_splice_without_unified_sigs: fails without this change.Changelog-None