Conversation
simolus3
requested changes
Sep 16, 2026
simolus3
left a comment
Collaborator
There was a problem hiding this comment.
I don't agree with this, and the test doesn't reproduce how PowerSyncControlArgument is actually used in invoke_control.
Semantically, we want to borrow the string to the SQLite statement, and the static destructor is acceptable for this. To make this cleaner rust, we could
- Mark
bind_toas unsafe, and add a safety comment stating that the reference must outlive the statement. - Explain that in
invoke_control, where we'd explicitly drop the statement before arguments.
Contributor
Author
|
Addressed in b0c1606: this keeps borrowed
|
simolus3
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
STATIC; SQLite does not need to copy them.unsafeand document its lifetime requirement.Root cause
The owned argument was declared after the statement, so normal Rust drop order could destroy it first.
STATICbindings require the backing value to outlive the statement.Validation
cargo fmt --all -- --checkcargo test -p powersync --all-featurescargo clippy -p powersync --all-targets -- -D warningsFixes #35