Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
17 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ZIP files acquired on macOS can carry decomposed Unicode labels. This change keeps extraction strict by default and offers NFC normalization only when the acquisition caller explicitly selects
NfcAtAcquisition.What changed
pp-sourceadds the explicit ZIP label policy while preserving raw central/local name checks, CRC and header validation, content bytes, digest computation, limits, and collision checks. Its accepted Stage 1 archive implementation and tests remain byte-identical in this publication.The native desktop composition adds bundle resource and dependency inventory checks, architecture-specific native addon staging, and captured runtime verification. The verifier checks the packaged Node 24.21.0 / ABI 137 identity, SQLite query, Canvas pixel and PNG output, expected addon paths, and measured Mach-O dependencies. Probe output is bounded to 4 KiB per stream, runs with a 30-second deadline, and must match the expected runtime identity. The compatibility supervisor retains bounded readiness and shutdown behavior.
The locked web dependency graph includes
better-sqlite313.0.3 and Knip 6.5.0. Fixture commands now take explicit output locations. The unrestricted quality command passed all nine stages: lint, full Knip, typecheck, unit tests, workflow smoke, build, bundle tests, runtime tests, and browser tests.Verification
Local quality passed with Node 24.21.0;
npm auditreported zero vulnerabilities. Plan fixtures validated 30 cases and 44 runtime inputs. Storage comparison found the schema and 16 databases byte-identical; the node-access database differed only in 12 generatedimported_atvalues. The accepted Source packet recorded 27pp-sourcetests. For this composed head, unchanged native, Rust, and Source checks are inherited scoped receipts and were not rerun; they cover only their exact unchanged source paths.The published commit has sole parent
b0561b7df2e298dc67ca7f1a2b110ebb587ab938, treefe27d5cffcaa7e206f4978fb213d79ccbae4bd62, and passed the immutable 18-path publication verifier.Deferred
Source codec/resolver work, HTTP acquisition, native picker behavior, U17 cutover, and full application acceptance remain open. Fresh hosted ARM and Intel artifacts from this head, installed UI and lifecycle checks, signing, notarization, quarantine, updater behavior, and native loading remain pending. Older Mac evidence was not reused as proof for this head.