SSR/SSG Hybrid - #1675
SSR/SSG Hybrid#1675crutchcorn wants to merge 10 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (7)
🚧 Files skipped from review as they are similar to previous changes (2)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe change adds static and SSR Docker runtimes, reusable Fly.io SSR deployment workflows, and staging configuration. It also standardizes localized 404 rewrites, validates missing content before rendering, and centralizes about-page path generation. ChangesSSR deployment and route validation
Priority: ➖ Normal Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant GitHubActions
participant Dockerfile
participant GHCR
participant Flyio
GitHubActions->>Dockerfile: Build with BUILD_OUTPUT=server
Dockerfile->>GHCR: Push server image
GitHubActions->>Flyio: Deploy image by digest
Flyio-->>GitHubActions: Return HTTPS hostname
Merge Risk: ⚪ Minimal · up to The deployment modes and localized route handling are ready to merge based on the reviewed changes. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 5 files. (6 skipped: 6 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| if (!collection || !author) { | ||
| return Astro.rewrite(localizeHref("/404")); | ||
| } |
There was a problem hiding this comment.
Why rewrite instead of assert here? IMO if these custom pages stop working we'll want them to error.
| name: Deploy SSR App | ||
|
|
||
| on: | ||
| workflow_call: |
There was a problem hiding this comment.
See discord comments - IMO this should only run on push to main. We should only need one staging app (total), not a new preview app for each branch/PR.
This PR adds in the SSR / SSG hybrid flag to support #1669
Summary by CodeRabbit
New Features
Bug Fixes