Release: gitleaks download retry (develop -> main) - #247
Merged
Merged
Conversation
#245) A single curl made a REQUIRED check fail in 3s when GitHub's release CDN returned a 504 (run 32473558686, release PR #176) — on a diff that could not possibly contain a secret — and the only recovery was a human re-run. Adds --retry 3 --retry-delay 2 --retry-all-errors to the install step's curl, per the issue. --retry-all-errors is the load-bearing flag: under -f a clean HTTP 504 response exits 22 without being retried by plain --retry. Audit of the sibling pinned-binary installs in this workflow: Trivy (aquasecurity/trivy-action), semgrep (container image), OSV-Scanner (google/osv-scanner-action) and TruffleHog (pinned action) download nothing with curl — the gitleaks step was the only release-tarball download in ci.yml. Same gap exists in security-audit.yml's identical gitleaks install step (out of this PR's stated scope; flagged for a follow-up). Validated: actionlint clean on the workflow; run block bash -n clean.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Squash-merged since the last release: