Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe ChangesLocal MATCH signature
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Feature Merge Risk: ⚪ Minimal · up to No actionable merge-blocking risk was identified in this protocol-only change. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit reads the MATCH enum line, Comment |
62b796e to
b80b669
Compare
b80b669 to
efddc9e
Compare
Summary
ScalarFuncSig_LocalMatchAgainstBoolean = 5250for row-wise Local MATCH Boolean evaluation.proto.lockfor the reserved scalar signature.The numeric ID is coordinated with the TiDB and TiFlash implementation branches. This reservation alone does not make older binaries execute Local MATCH.
Validation
GOCACHE=/private/tmp/tipb-go-cache GOWORK=off go test ./go-tipb— passed (package compiles; no test files).protolock status -lockdir=scripts -protoroot=proto— passed.37879755411— Go, C++, and Rust generation checks all passed; CLA check passed.