fix: prevent ERR_HTTP_HEADERS_SENT when response headers sent during request wait - #166
Closed
vaibhavmashal wants to merge 1 commit into
Closed
Conversation
|
Duplicate of #163 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #162
Description
When a request has an unread body, \ inalhandler\ registers an \onFinished(req, write)\ callback to defer sending the response until the request stream finishes. If another middleware or asynchronous operation sends response headers during this wait,
es.headersSent\ becomes \ rue. When \write()\ is subsequently executed, modifying headers or status code threw an \ERR_HTTP_HEADERS_SENT\ error.
This PR adds an early return check \if (res.headersSent) { return }\ inside \write()\ in \index.js\ and adds unit tests covering this scenario.