Define wpdb named-column retirement contract - #42
Draft
alexstandiford wants to merge 13 commits into
Draft
alexstandiford wants to merge 13 commits into
alexstandiford wants to merge 13 commits into
Conversation
alexstandiford
force-pushed
the
codex/real-wpdb-query-contract-tests
branch
from
September 20, 2026 17:06
a43199e to
7df38e0
Compare
alexstandiford
force-pushed
the
packet/table-column-retirement-wordpress
branch
from
September 20, 2026 17:24
0d0c34c to
2e5b5a6
Compare
alexstandiford
force-pushed
the
codex/real-wpdb-query-contract-tests
branch
from
September 20, 2026 17:25
21b25c4 to
111135d
Compare
alexstandiford
force-pushed
the
packet/table-column-retirement-wordpress
branch
from
September 20, 2026 17:51
3e88a55 to
37b89bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the optional named-column retirement capability for the WordPress adapter while preserving the corrected #41 protected extension surface and making ordinary sync additive. The official-wpdb strategy resolves both base and retirement interfaces to one configured instance. Requested and declared names use the backend metadata identifier collation even when a declared column is absent; aliases deduplicate to one persisted target. Full preflight validates the complete batch, rejects malformed metadata, and refuses declared columns, index dependencies, unresolved functional-index metadata, and foreign keys before DDL.
Persisted official-wpdb/MySQL 8.0.45 fixtures cover active-schema scoping, absent declared ASCII/Unicode case variants, the distinct legacy/légacy accent boundary, additive sync, mixed present/absent retirement, deduplication/idempotence, invalid-batch atomicity, quoted identifiers, preserved data, and dependency guards. Unit boundary fixtures honor requested COLUMN_NAME and identifier-comparison predicates without weakening assertions.
This PR is based on corrected #41 head c98c432 and preserves its official WordPress bootstrap, query contracts, protected APIs, and dual optional/required integration scripts. Temporary dependency files resolve phpnomad/db#38 at 406843bc0eefeeadc6fecb847f6e9f3b596458a5 through the branch alias over HTTPS. Release sequence: land/release DB #38 and replace the temporary alias with the released constraint, land #41, then merge/release this adapter. No tag or release is created here.
Architecture: Named Table Column Retirement Contract (Source 9972)