[SOAP] Fix WSDL cache corruption when header defines headerfaults - #23502
Open
iliaal wants to merge 1 commit into
Open
[SOAP] Fix WSDL cache corruption when header defines headerfaults#23502iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
devnexen
requested changes
Aug 29, 2026
| soap.wsdl_cache_enabled=1 | ||
| --FILE-- | ||
| <?php | ||
| $dir = sys_get_temp_dir() . '/wsdlcache' . getmypid(); |
Member
There was a problem hiding this comment.
every time a resource is created, database, temp files ... a clean section is needed so if the test fails before the ends it gets clean up no matters what.
| const zend_string *key_inner; | ||
|
|
||
| ZEND_HASH_MAP_FOREACH_STR_KEY_PTR(body->headers, key_inner, tmp2) { | ||
| ZEND_HASH_MAP_FOREACH_STR_KEY_PTR(tmp->headerfaults, key_inner, tmp2) { |
Member
There was a problem hiding this comment.
fine fix, however then the cache needs a bump (WSDL_CACHE_VERSION) -> 0x11
sdl_serialize_soap_body() counted j headerfaults per header but then serialized body->headers instead of tmp->headerfaults, writing N header records where j fault records were expected by sdl_deserialize_soap_body(), misaligning the cache stream and crashing on load whenever a soap:header carries headerfaults. Iterate tmp->headerfaults instead; sibling audit of the other serialize/deserialize loops in php_sdl.c found no further hash-mismatched iteration. Bump WSDL_CACHE_VERSION so existing on-disk caches are discarded.
iliaal
force-pushed
the
fix/sdl-headerfault-cache-mkj-84
branch
from
August 29, 2026 15:01
e71448f to
852426e
Compare
devnexen
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sdl_serialize_soap_body() counted j headerfaults per header but serialized
the body->headers hash table instead of tmp->headerfaults, writing N header
records where the deserializer expects j fault records. Any soap:header with
soap:headerfault children misaligns the WSDL cache stream; loading the cached
SDL segfaults. Reproduced with two headers, one headerfault each, on a second
cache-hitting SoapClient construction. The inner loop now iterates
tmp->headerfaults. No other loop in php_sdl.c mismatches.