Repository navigation
Conversation
Require a resolved PHPUnit Assert/TestCase declaration before rewriting assertion methods. Preserve custom, magic, trait-required and unresolved calls. Give existing method-call fixtures PHPUnit ancestry and scan reflection-only assertion declarations without loading fake runtime PHPUnit classes. Refs php-testo#390 Assisted-By: GPT-6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rector currently recognises PHPUnit assertion methods by call shape and name. A project method such as
assertSame()orassertIsString()can therefore be rewritten even when it has its own implementation and return value.Require the resolved method declaration to belong to PHPUnit's Assert or TestCase. Custom, inherited custom, magic, trait-required and unresolved methods stay unchanged. PHPUnit assertion functions keep their namespace-based recognition.
Only the shared assertion recogniser changes in production. The broad fixture edit adds PHPUnit ancestry to 33 existing method-call fixtures; function-call fixtures retain their existing ancestry. Reflection-only PHPUnit declarations are scanned by PHPStan without loading fake runtime classes into Double or other bridges.
Validation:
Part of #390. Named string arguments, weak/strict coercion and evaluation order are handled in #396. Both PRs target 1.x independently; review this ownership change first.