Format a shipping week with the week year - #46
Merged
Merged
Conversation
30 December 2024 was encoded as 202401. That Monday is ISO week 1 of 2025, so the code is 202501. 1 January 2020 stays 202001.
Contributor
Author
|
Thanks for merging this. |
SashaMIT
added a commit
to SashaMIT/oss-contributions
that referenced
this pull request
Sep 26, 2026
Contributor
|
Thank you for the PR 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EdifactDate::get('2024-12-30', EdifactDate::SHIPPING_WEEK)returned202401. Format 616 uses PHPW, the ISO week number, but the year token wasY. 30 December 2024 is a Monday in ISO week 1 of 2025, so the code is202501.2020-01-01still returns202001.Test plan
./vendor/bin/phpunit --filter testShippingWeekUsesTheWeekYearfailed before the fix (202401did not match202501) and passes after it./vendor/bin/phpunit(34 tests)Made with Cursor