fix: populate mstraj velocity and acceleration - #706
Open
Doribelove wants to merge 1 commit into
Open
Doribelove wants to merge 1 commit into
Doribelove wants to merge 1 commit into
Conversation
Collect the analytic derivatives of polynomial blends and the constant velocity and zero acceleration of linear segments alongside the existing position samples. Document the returned trajectory fields and cover blended and unblended paths. Assisted-by: OpenAI Codex Signed-off-by: 李永祺 <doribelove@gmail.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #706 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 143 143
Lines 14269 14280 +11
=====================================
- Misses 14269 14280 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mstraj()returned aTrajectorywith positions only, leaving its publicqdandqddproperties asNone. This change carries the analytic velocity and acceleration from eachjtrajpolynomial blend into the output, and assigns constant velocity and zero sampled acceleration to each linear segment. It also marks the time-based trajectory asistime=Trueand documents the returned fields and the instantaneous velocity changes whentacc=0.The original position, time, arrival and segment metadata remain unchanged. In 50 generated cases, these fields matched upstream
mainexactly.Related issue
Fixes #497.
Validation
Noneresult on upstreammain; with the fix,tests/test_trajectory.pyandtests/test_tools.pypass: 23 passed, 18 subtests passed on Python 3.12.qdandqddarrays with the same shape asq.ruff format --checkandgit diff --checkpass.ruff checkreports the same 15 pre-existing findings on both upstreammainand this branch; this PR adds none.test_BaseRobot.py::test_ets_gripper2timed out whilerobot_descriptionsfetched the external YuMi model assets. No failure was observed in the trajectory tests.Checklist
mstrajand its trajectory tests.The patch was developed with assistance from OpenAI Codex. The commit is signed off by 李永祺 doribelove@gmail.com.