Move the page to /word-addin: the deploy already owns /word - #93
Merged
Merged
Conversation
The navigation link led to the task pane, not to the page written for it. On the host a real directory beats a client-side route, and the deploy publishes the pane at /word/ — so /word answered with the pane, which outside Word says it has no document to read. Invisible locally, because a dev server has neither directory. Invisible in the diff, because the two halves are in different files: an @page in a component and a cp in a workflow. The pane keeps its address, because that address is in a manifest people have already installed. The page moves. DeployedPathTests guards both ends of the seam. One reads every @page route from the components and the pane's directory from the workflow, and fails when they collide; the other checks the manifest's SourceLocation still points at the directory the deploy actually writes, which is the failure that made the first install report an add-in error. Verified by mutation: put /word back and the first fails by name. 434 tests. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015PEbbiYSNPw7jE3LrPNhyF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live on
mainright now, so worth merging before anything else: the Word link in the navigation leads to the task pane, not to the page written for it.On the host a real directory beats a client-side route, and the deploy publishes the pane at
/word/. So/wordanswers with the pane, which outside Word says it has no document to read.Why it got through
Invisible locally — a dev server has neither directory. Invisible in the diff — the two halves live in different files: an
@pagein a component and acpin a workflow. It only exists once both are deployed onto one host.The pane keeps its address
That address is in a manifest people have already installed. The page moves to
/word-addin.Guarded at both ends of the seam
DeployedPathTests:@pageroute from the components and the pane's directory from the workflow, and fails when they collide;SourceLocationstill points at the directory the deploy actually writes — which is the failure that made the very first install report "this add-in may not load properly."Neither number is typed twice: the point is that the two sources are compared. Verified by mutation: put
/wordback and the first fails by name.434 tests.
🤖 Generated with Claude Code
https://claude.ai/code/session_015PEbbiYSNPw7jE3LrPNhyF