Repository navigation
fix(number-fields): align Currency, Decimal, Integer and Percentage with Constellation - #638
Merged
Merged
Conversation
tammy-a11y
previously approved these changes
Oct 13, 2026
…ith Constellation Currency, Decimal, Integer and Percentage fields now format, parse and save values the same way as the Constellation DX components. - Use the operator locale (PCore getLocale) and the configured ISO code directly, instead of the country-map lookup. - Currency input: place the symbol before or after the number per locale, honor "Show ISO Code", and use the currency's own decimal places (e.g. JPY = 0). NOK now shows "NOK"/"kr" instead of "$". - Percentage input: place the % sign per locale and support storePercentageAsDecimal (show 25 for 0.25, save 25 as 0.25). - Integer input: replace type="number" with a masked input that uses locale grouping and 0 decimals. - Decimal input: use locale separators and stop adding $/% to read-only inputs. - Save a number (or '' when cleared) instead of a formatted string, e.g. -100 rather than "-$100.00". Only save when the value changed; re-validate a field that stays empty. - Show a value of 0 instead of treating it as empty. - Read-only display follows the "Format" setting (Integer, Decimal, Decimal-Auto, Percentage, Currency) plus currency display, negative number display, notation and decimal places shown, through a shared formatNumberFieldForDisplay helper. - format-utils: switch the Currency formatter to Intl, fix type errors, and remove dead/duplicated code. - Add lodash.get as a dependency. Refs: EA-D16359
tumms2021389
force-pushed
the
fix/dec/EA-D16359
branch
from
October 13, 2026 07:06
0ff8c63 to
56e1db3
Compare
SambhuPega
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currency, Decimal, Integer and Percentage fields now format, parse and save values the same way as the Constellation DX components.
Refs: EA-D16359