BUG: Fix return_annotation() skipping fallback for C-builtins - #475
Open
knarfS wants to merge 1 commit into
Open
BUG: Fix return_annotation() skipping fallback for C-builtins#475knarfS wants to merge 1 commit into
knarfS wants to merge 1 commit into
Conversation
knarfS
changed the title
knarfS
force-pushed
the
issue_474
branch
3 times, most recently
from
August 16, 2026 15:22
ce71eca to
c703e86
Compare
Continue fallback when `inspect.signature().return_annotation` returns `Parameter.empty`, allowing return annotations to be parsed from C-buildins docstrings. Remove misleading `UserWarning: Error handling return annotation for ...`. Empty return annotations are totally normal and expected for many function signatures. This fixes pdoc3#474
knarfS
added a commit
to knarfS/smuview
that referenced
this pull request
Aug 29, 2026
The current pdoc3 implementation has several bug regarding pybind11 docstrings. At the moment, these PRs are pending: - pdoc3/pdoc#475 - pdoc3/pdoc#477 This commit can be reverted when PRs are merged and no new PRs were added.
knarfS
added a commit
to knarfS/smuview
that referenced
this pull request
Aug 29, 2026
The current pdoc3 implementation has several bugs regarding pybind11 docstrings. At the moment, these PRs are pending: - pdoc3/pdoc#475 - pdoc3/pdoc#477 This commit can be reverted when PRs are merged and no new PRs were added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue fallback when
inspect.signature().return_annotationreturnsParameter.empty, allowing return annotations to be parsed from C-buildins docstrings.Remove misleading
UserWarning: Error handling return annotation for ....Empty return annotations are totally normal and expected for many function
signatures.
This fixes #474