Skip to content

Fix typo in error handling section of README - #21

Merged
simonc merged 1 commit into
pdfmonkey:masterfrom
mickeytgl:patch-1
Oct 1, 2025
Merged

simonc merged 1 commit into
pdfmonkey:masterfrom
mickeytgl:patch-1

Conversation

@mickeytgl

Copy link
Copy Markdown
Contributor

No description provided.

@simonc

simonc commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

Hi @mickeytgl thanks for opening this PR 😊

Sadly it's only a partial fix as both statements are true, it's sometimes error and sometimes errors (I know… that's 💩)

But nonetheless, you're right, this section should clarify the situation, which mostly boils down to: general errors like auth issue or bad request will get an error key while validation errors like missing template ID will be listed under errors.

@simonc

simonc commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

@mickeytgl Looking at the code, I realise I actually fixed the API issue in the gem and normalized around document.errors for everything so your PR is correct. My bad! 😅

@simonc
simonc merged commit 9b80aa6 into pdfmonkey:master Oct 1, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants