Conversation
payjoin-cli and payjoin-mailroom used payjoin-test-utils only in tests, but named it by version, so cargo kept the dependency in the published manifest and the crate had to be on crates.io before either of them could be released. payjoin-test-utils depends on payjoin-mailroom, so the two could not be published in any order without a dangling dev-dependency. A dev-dependency with a path and no version is dropped from the published manifest. Test builds inside the workspace are unchanged. payjoin-test-utils no longer needs a crates.io release ahead of its dependents.
Collaborator
Coverage Report for CI Build 36992736431Coverage remained the same at 87.289%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
payjoin-cli 1.0.0, re-cut from the 1.2.0 bump instead of the five-PR stack. Two commits.
The first makes payjoin-cli's and payjoin-mailroom's dev-dependency on payjoin-test-utils path-only. Cargo drops a path-only dev-dependency from the published manifest, so test-utils no longer has to be on crates.io before either crate can be released, and the dev-dependency cycle between test-utils and mailroom stops mattering for publishing. Tests inside the workspace are unchanged. Checked by packaging mailroom from master with the same edit: the packaged manifest keeps rcgen and reqwest and has no mention of test-utils. Both lock files verified consistent with
cargo metadata --locked.The second is Ben's bump commit from #1936, cherry-picked with his authorship. check-invariants passes for payjoin-cli 1.0.0. The publish dry run cannot run until payjoin 1.2.0 is on crates.io, for the same reason
check-bumpskips it.Replaces #1934 and #1936. Based on #1931; GitHub retargets this to master when that merges.
Reviewer: @benalleng
Prepared with Claude Code from Ben's commit; I reviewed the diff and the gate output.