Conversation
Coverage Report for CI Build 36739672490Coverage remained the same at 87.074%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
DanGould
left a comment
DanGould
left a comment
There was a problem hiding this comment.
utACK 5b6aac2
Kind of verbose and I think somewhat incorrect changelog. Also, this PR could be a stack to make merging easier.
master
└─ bump payjoin 1.2.0 (#1929)
└─ bump payjoin-mailroom
└─ bump payjoin-test-utils
└─ bump payjoin-ffi / payjoin-cli
that released all this stuff at once so we don't run into the same problem again.
| ### Bug Fixes | ||
|
|
||
| - Reject proposals that drop or reorder the sender's original inputs | ||
| before classifying any input as sender or receiver contributed. Input | ||
| classification treated any proposed input whose outpoint did not match | ||
| an original one as receiver-contributed, so a receiver that altered a | ||
| sender outpoint was validated as though the receiver had contributed | ||
| it, and the sender only learned something was wrong from a later | ||
| finalization error that pointed at the wrong thing. Dropped and | ||
| reordered inputs are now both rejected up front with | ||
| `MissingOrShuffledInputs` (#1836) |
There was a problem hiding this comment.
I don't think this was actually a bug fix, just a misleading commit log that led to this. This was a test adjustment
There was a problem hiding this comment.
Doesn't is_ordered_subsequence() in 283663e actually cover a real issue?
5b6aac2 to
1e4a274
Compare
To make a stack it would all need to come from my master branch at once. let me try to see what that looks like |
1e4a274 to
3e04188
Compare
|
I think you can push a bunch of different branches to this repository and stack them, no? |
|
Will do, just practicing on my fork now |
This is a minor release as it adds the non-blocking interface and the related methods that can now be used instead of synchronous callbacks. This all keeps the existing methods so it remains backwards compatible.
3e04188 to
db2e5ee
Compare
|
Closed as replaced by #1931 |
3 participants
This is a minor release as it adds the non-blocking interface and the related methods that can now be used instead of synchronous callbacks. This all keeps the existing methods so it remains backwards compatible.
GLM-5.3 helped me generate the changelog text.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.
reviewer
in the body of this PR.