Fix /check-in issue with "Issues Opened" and "PRs Opened" - #1928
Conversation
Coverage Report for CI Build 36761240492Coverage remained the same at 87.074%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
DanGould
left a comment
There was a problem hiding this comment.
tentative utACK 4f3708f because this is just check-in scripts, nondangerous changes waiting confirmation on the below:
let me know if there is a specific flow I should use for testing this
Did you at least run it locally to see if it works? or --dry-run it? or run the actions on a GitHub fork? There's no specific flow but some nonzero testing ("works on my machine") seems in order for any PR, and it's missing here.
4463d28 to
f9fd13f
Compare
|
It didn't even occur to me that you could test but its obvious in hindsight. Sorry about that. Added dry-run mode and tested locally, Testing sample: ShippedPRs merged:
PRs opened:
PRs reviewed: Issues opened: Auto-detected signals:
|
Currently
/check-incommand groups opened PRs under "Issues Opened" section. These changes:Closes #1918 .
Assigning @DanGould for review. Have never worked with this stuff before so let me know if there is a specific flow I should use for testing this.
Disclosure: co-authored by Sol 5.6
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.
reviewer
in the body of this PR.