Skip to content

Fix /check-in issue with "Issues Opened" and "PRs Opened" - #1928

Merged
DanGould merged 3 commits into
payjoin:masterfrom
xstoicunicornx:fix/check-in-issue-filter
Oct 2, 2026
Merged

DanGould merged 3 commits into
payjoin:masterfrom
xstoicunicornx:fix/check-in-issue-filter

Conversation

@xstoicunicornx

Copy link
Copy Markdown
Collaborator

Currently /check-in command groups opened PRs under "Issues Opened" section. These changes:

  • Only include issues under "Issues Opened"
  • Creates new section for "PRs Opened"

Closes #1918 .

Assigning @DanGould for review. Have never worked with this stuff before so let me know if there is a specific flow I should use for testing this.

Disclosure: co-authored by Sol 5.6

Pull Request Checklist

Please confirm the following before requesting review:

@coveralls

coveralls commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 36761240492

Coverage remained the same at 87.074%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 17353
Covered Lines: 15110
Line Coverage: 87.07%
Coverage Strength: 327.73 hits per line

💛 - Coveralls

DanGould
DanGould previously approved these changes Sep 30, 2026

@DanGould DanGould left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tentative utACK 4f3708f because this is just check-in scripts, nondangerous changes waiting confirmation on the below:

let me know if there is a specific flow I should use for testing this

Did you at least run it locally to see if it works? or --dry-run it? or run the actions on a GitHub fork? There's no specific flow but some nonzero testing ("works on my machine") seems in order for any PR, and it's missing here.

@xstoicunicornx
xstoicunicornx force-pushed the fix/check-in-issue-filter branch from 4463d28 to f9fd13f Compare September 30, 2026 18:48

@DanGould DanGould left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4f3708f

@DanGould
DanGould merged commit d14174a into payjoin:master Oct 2, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check-in Issues Opened lists PRs Opened

3 participants