Repository navigation
fix(plannotator): recover orphaned reviews and report already-active refusals - #11
Merged
patleeman merged 2 commits intoOct 13, 2026
Merged
Conversation
…refusals - The Plannotator panel action now asks the server for the thread's pending review when it opens without params, so a review whose tab was closed can still be approved, annotated, or cancelled. It follows review-opened and a new review-closed realtime signal. - A second plannotator_review_plan call while one is pending returns status "already_active" with the pending reviewId instead of decision "cancelled". - Bump to 0.3.1. Fixes #9 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…'s decision A slow or retried decision send no longer blocks the next review. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9
Thanks @irium for the detailed report. The diagnosis in
app.tsxand the suggested fix were spot on, and this PR follows them closely.Changes
PlannotatorPanelcallsgetActiveReview(threadId)and renders the pending review, including Cancel review. A param-less panel also followsreview-openedsignals and a newreview-closedsignal, so it returns to the empty state when the review ends. Server-opened tabs still close as before.plannotator_review_plancall while a review is pending now returns{"status":"already_active","reviewId":"<pending id>", ...}withisError: true. It no longer returnsdecision: "cancelled". The skill and README explain this.PlannotatorFocusBridgestill does not reopen a tab the user closed. The review is recovered through the panel action.Tests
app.test.tsx: a param-less panel recovers and cancels the active review, and it follows open and close signals, ignoring other threads.server.test.ts: a second call returnsalready_activewith the pending review ID and nodecision. The pending review stays recoverable and cancellable, andreview-closedis published.mainand pass with this change. Packagetypecheckand the full test suite (45 tests) pass, and so doespnpm check:compat.🤖 Generated with Claude Code