Skip to content

fix: incorrect env var for base64 signature - #1779

Merged
nikhilsinhaparseable merged 1 commit into
parseablehq:mainfrom
nikhilsinhaparseable:fix/interactive
Sep 3, 2026
Merged

fix: incorrect env var for base64 signature#1779
nikhilsinhaparseable merged 1 commit into
parseablehq:mainfrom
nikhilsinhaparseable:fix/interactive

Conversation

@nikhilsinhaparseable

@nikhilsinhaparseable nikhilsinhaparseable commented Sep 3, 2026

Copy link
Copy Markdown
Member

current env prompt - P_LICENSE_SIGNATURE_BASE64_FILE_PATH -- incorrect server never expects base64 file path

update to P_LICENSE_SIGNATURE_BASE64

Summary by CodeRabbit

  • Bug Fixes
    • Updated enterprise setup to prompt for the license signature value directly.
    • Revised the displayed label for this setup prompt.

current env prompt - P_LICENSE_SIGNATURE_BASE64_FILE_PATH -- incorrect
server never expects base64 file path

update to P_LICENSE_SIGNATURE_BASE64
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Essentials

Run ID: afeabba2-6ce3-4d5d-8c07-6219bc0ac07e

📥 Commits

Reviewing files that changed from the base of the PR and between 936000f and bd6c778.

📒 Files selected for processing (1)
  • src/interactive.rs

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


Walkthrough

The enterprise setup prompt now requests the license signature through P_LICENSE_SIGNATURE_BASE64 instead of a file path variable. The prompt display label was also updated.

Changes

Enterprise license prompt

Layer / File(s) Summary
Update signature prompt
src/interactive.rs
The enterprise license prompt now collects the base64 signature directly through P_LICENSE_SIGNATURE_BASE64.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to bd6c7

Enterprise setup now requests the base64 license signature through the server-expected environment variable, with no identified merge-readiness risk.

Poem

A rabbit types a key,
The license blooms in base64,
No file path hops along,
The prompt now names the way,
And setup ends with cheer.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the fix to the incorrect base64 signature environment variable. It is concise and matches the main change.
Description check ✅ Passed The description clearly states the incorrect variable and the replacement expected by the server. It omits the template headings and testing checklist, but it provides the essential context for this s…
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description clearly states the incorrect variable and the replacement expected by the server. It omits the template headings and testing checklist, but it provides the essential context for this small change.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@nikhilsinhaparseable
nikhilsinhaparseable merged commit cff42a4 into parseablehq:main Sep 3, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants