Skip to content

🚸 ux(iaas): improve base64 & file flags use + retrocompatibility - #345

Merged
jfbus merged 1 commit into
mainfrom
file_retrocompat
Sep 17, 2026
Merged

jfbus merged 1 commit into
mainfrom
file_retrocompat

Conversation

@jfbus

@jfbus jfbus commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Description

This PR configures all flags used for certificates/keys as file flags.

To ensure a good retrocompatibility, all file flags allow passing the file content as flag value.

Type of Change

Please check the relevant option(s):

  • 🐛 Bug fix
  • ✨ New feature
  • 🧹 Code cleanup or refactor
  • 📝 Documentation update
  • 🔧 Build or CI-related change
  • 🔒 Security fix
  • Other (specify): ux

How Has This Been Tested?

Please describe the test strategy:

  • Manual testing
  • Unit tests
  • Integration tests
  • Not tested yet

Checklist

  • I have followed the Contributing Guidelines
  • I have added tests or explained why they are not needed
  • I have updated relevant documentation (README, examples, etc.)
  • My changes follow the Conventional Commits specification
  • My commits include appropriate Gitmoji

Additional Context

@github-actions

Copy link
Copy Markdown

WARNING : Differences in reference doc 🤔

 docs/reference/octl_iaas_api_CreateCa.md                |  2 +-
 docs/reference/octl_iaas_api_CreateServerCertificate.md | 14 +++++++-------
 docs/reference/octl_iaas_ca_create.md                   |  2 +-
 docs/reference/octl_iaas_servercertificate_create.md    |  6 +++---
 4 files changed, 12 insertions(+), 12 deletions(-)
Detailed changes

docs/reference/octl_iaas_api_CreateCa.md

-      --CaPem string         [REQUIRED] The CA in PEM format.
+      --CaPem file           [REQUIRED] The file storing the CA in PEM format.

docs/reference/octl_iaas_api_CreateServerCertificate.md

-      --Body string         [REQUIRED] The PEM-encoded X509 certificate.
-      --Chain string        The PEM-encoded intermediate certification authorities.
+      --Body file         [REQUIRED] The file storing the PEM-encoded X509 certificate.
+      --Chain file        The file storing the PEM-encoded intermediate certification authorities.
-      --PrivateKey string   [REQUIRED] The PEM-encoded private key matching the certificate.
+      --PrivateKey file   [REQUIRED] The file storing the PEM-encoded private key matching the certificate.

docs/reference/octl_iaas_ca_create.md

-      --pem string           [REQUIRED] The CA in PEM format.
+      --pem string           [REQUIRED] The file storing the CA in PEM format.

docs/reference/octl_iaas_servercertificate_create.md

-      --body string          [REQUIRED] The PEM-encoded X509 certificate.
-      --chain string         The PEM-encoded intermediate certification authorities.
+      --body string          [REQUIRED] The file storing the PEM-encoded X509 certificate.
+      --chain string         The file storing the PEM-encoded intermediate certification authorities.
-      --private-key string   [REQUIRED] The PEM-encoded private key matching the certificate.
+      --private-key string   [REQUIRED] The file storing the PEM-encoded private key matching the certificate.

@github-actions

Copy link
Copy Markdown

No flags have changed or have been deleted 😀

@github-actions

Copy link
Copy Markdown

Binary size: 82.3MB => 82.3MB (change +0KB, +0.0%) 😉

@jfbus
jfbus marked this pull request as ready for review September 17, 2026 07:12
@jfbus
jfbus requested a review from a team September 17, 2026 07:12
@jfbus
jfbus requested a review from a team as a code owner September 17, 2026 07:12
@jfbus jfbus added the kind/other Other change label Sep 17, 2026
outscale-rce
outscale-rce previously approved these changes Sep 17, 2026
@github-actions

Copy link
Copy Markdown

No flags have been deleted 😀

@jfbus
jfbus merged commit 2c7bc8a into main Sep 17, 2026
9 checks passed
@jfbus
jfbus deleted the file_retrocompat branch September 17, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/other Other change

Development

Successfully merging this pull request may close these issues.

2 participants