Repository navigation
AO3-7523 Fix conflicting error messages shown when claiming a non-canonical fandom as a wrangler - #6063
Open
JSLarson wants to merge 3 commits into
Open
AO3-7523 Fix conflicting error messages shown when claiming a non-canonical fandom as a wrangler#6063JSLarson wants to merge 3 commits into
JSLarson wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7523
Purpose
Changes success popup logic to only appear upon true successful assignment. Previously the success popup appeared whenever the form "assignments" was sent, even if it was empty. After this fix, attempting to self-assign a non-canonical fandom will show only the error popup.
Note both messages will still appear if you simultaneously self-assign both a canonical and non-canonical fandom. As far as I can tell, this is intended behavior.
Credit
James Larson (he/she)