Skip to content

AO3-7594 Update html in invalid_signup_notification.html.erb mailer - #6015

Merged
sarken merged 2 commits into
otwcode:masterfrom
delphi121:invalid-signup-html-fix
Sep 29, 2026
Merged

sarken merged 2 commits into
otwcode:masterfrom
delphi121:invalid-signup-html-fix

Conversation

@delphi121

@delphi121 delphi121 commented Sep 6, 2026 •

Copy link
Copy Markdown
Contributor

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-7594

Purpose

Updates the HTML to be consistent with the rest of the mailers, by moving the ul element out of the p element.

Testing Instructions

A visit to the mailer preview at https://test.archiveofourown.org/rails/mailers/gift_exchange_mailer/ will confirm the HTML cleanup still displays the list element as intended.

Credit

bowekatan
She/her

@sarken

sarken commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Hi, bowekatan!

Thank you so much for this pull request. Someone will be along to review it soon.

In the meantime, I've assigned the Jira issue to you and set its status to In Review, so no one mistakenly creates a duplicate pull request. I've also given your account permission to comment on, assign, and transition issues in the future.

Thanks again for contributing! If you have any questions, you can contact us at otw-coders@transformativeworks.org.

@delphi121 delphi121 changed the title AO3-7594 Updated html in invalid_signup_notification.html.erb mailer AO3-7594 Update html in invalid_signup_notification.html.erb mailer Sep 8, 2026

@ASalbenblatt ASalbenblatt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small formatting issue :)

Comment thread app/views/gift_exchange_mailer/invalid_signup_notification.html.erb Outdated

@sarken sarken left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have time to action the comment from @ASalbenblatt, that would be great! However, it's not blocking, so I'm going to mark this approved.

Fixed the small formatting/indentation issue

@ASalbenblatt ASalbenblatt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!!

@sarken
sarken merged commit b1e8d7b into otwcode:master Sep 29, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants