AO3-4052 Require choosing a pseud option when orphaning

[pmonfort]

Pull Request Checklist

• Have you read the contributing guidelines?
• Have you read "How to write the perfect pull request"?
• Have you added tests for any changed functionality?
• Have you added the Jira issue number as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
• Do you have fewer than 5 pull requests already open? If not, please wait until they are reviewed and merged before creating new pull requests.
• I acknowledge that submitting code created or modified with the help of AI is a bannable offense.

Issue

https://otwarchive.atlassian.net/browse/AO3-4052

Purpose

The orphan page preselected "Take my pseud off as well", so it was easy to orphan without reading the options. This PR:

• Removes the default, so neither option is checked when the page loads.
• Makes OrphansController#create reject the form when no option (or an unexpected value) is submitted, with an error and a redirect back to the orphan page.
• Reworded the options to "Remove my pseud" / "Keep my pseud", as suggested in the issue comments, and gave the group a visible prompt ("What should happen to your pseud?") plus a legend for screen readers, following the pattern used in the work form.

The partial is shared by the work, series, pseud and account orphan pages, so all four are affected.

Testing Instructions

1. Log in, open a work you created, click Edit, then "Orphan Work".
2. Neither option should be selected. The group should read "What should happen to your pseud?" with the options "Remove my pseud" and "Keep my pseud".
3. Click "Yes, I'm sure" without choosing: you should stay on the orphan page with the error "You must choose whether to remove or keep your pseud." and the work should still be yours.
4. Choose "Keep my pseud" and confirm: the work is orphaned with a copy of your pseud (<pseud> (orphan_account) in the byline, unless the work is in an anonymous collection).
5. Repeat with another work and "Remove my pseud": the byline shows orphan_account.
6. The same check applies on the series, pseud and whole-account orphan pages.

Credit

Pablo Monfort (he/him)

[sarken]

Assigning myself as reviewer on this since I have started, but it might be a few days because I want to poke at the form layout a bit!

[sarken]

Thanks for realizing the form needed some context with this change! 😆 I looked at it a bit and I think I found a slightly simpler design pattern to use for it, even though it involves a little more work.

[sarken]

I think the three of these can be replaced with this step:

otwarchive/features/step_definitions/orphan_steps.rb

Lines 13 to 18 in b5f5328

	When /^I begin orphaning the work "([^"]*)"$/ do |name|
	step %{I wait 1 second}
	step %{I edit the work "#{name}"}
	step %{I follow "Orphan Work"}
	step %{I should see "Orphan Works"}
	end

[sarken]

How about updating these step definitions to use choose("use_default_false") and choose("use_default_true") while we're here? We do prefer the user-facing label text in the feature files themselves, but the IDs are fine and usually less brittle for the step definitions.

[sarken]

I think we can simplify this form considerably by just using this fieldset and no dl (and changing the .prompt key to .legend while we're there).

In order to make the legend visible, though, we'll need to add the classes single simple post to the form elements that use this partial.

Here's a preview of how the form should look once those changes are made:

Lastly, we should update the comment on the CSS for our single design pattern to say /* mods: SINGLE for prominent simple forms consisting of one text input (e.g., on the blocked user page) or group of checkboxes or radios (e.g., on the orphan work page) */

[sarken]

Since this is slightly different from providing no option, let's pull this out into its own context, like context "when invalid pseud option is provided".