Repository navigation
Conversation
sherin
changed the title
sarken
changed the title
ASalbenblatt
left a comment
ASalbenblatt
left a comment
There was a problem hiding this comment.
Just a few small fixes :)
| # Redirects for moved help files | ||
| get "/help/add-collectible-to-collection.html", to: redirect("/help/collectibles_add_to_collection") | ||
| get "/first_login_help", to: redirect("/help/first_login") | ||
| get "/help/chapter-title.html", to: redirect("/help/chapters_title") |
There was a problem hiding this comment.
This line isn't alphabetized correctly, it should go first like how you have it in help_controller.rb
| prev: "← Previous" | ||
| people: | ||
| search_form: | ||
| people_search_all_fields_help_title: People search all fields help |
There was a problem hiding this comment.
The key for this doesn't need to include people_search_ because it's already at people.search_form
| unwanted_larger_text: If one bit of your text shows up larger than the rest, probably our formatter couldn't figure out to put paragraph tags around it. You can fix this by manually putting in the paragraph tags around that one bit. | ||
| unwilling_to_break: If you have put in some custom HTML (eg a list of items inside a <ul>) and you don't want break tags or paragraphs inserted, just put it all on one line (sorry, this is the inconvenient tradeoff for automatically doing the paragraph/break tags). | ||
| page_heading: HTML on the Archive | ||
| people_search_all_fields: |
There was a problem hiding this comment.
I'm just putting this here because it comes up a lot in this file, but translators shouldn't be expected to know what kbd and samp mean. I might instead use something more descriptive like as_entered and result respectively (or whatever you want if you can come up with something clearer or better)
There was a problem hiding this comment.
Makes sense. I liked using the tags itself because it was very confusing w/o them. Hmm I will use "sample" for samp and keyboard_input for kbd
| user_samp: User | ||
| username_samp: Username | ||
| users_samp: Users | ||
| exact: |
There was a problem hiding this comment.
I think this would be better described as double_quotes:
| description_html: "%{a_user_kbd} will find %{a_user_samp} and %{a_test_user_samp} but not %{user_samp}." | ||
| title: 'space: a space acts like AND' | ||
| user_samp: User | ||
| any: |
There was a problem hiding this comment.
I think this would be better described as asterisk:
| unwilling_to_break: If you have put in some custom HTML (eg a list of items inside a <ul>) and you don't want break tags or paragraphs inserted, just put it all on one line (sorry, this is the inconvenient tradeoff for automatically doing the paragraph/break tags). | ||
| page_heading: HTML on the Archive | ||
| people_search_all_fields: | ||
| and: |
There was a problem hiding this comment.
I think this would be better described as space:
| exact: | ||
| a_test_user_samp: A. Test User | ||
| a_user_kbd: '"A. User"' | ||
| a_user_samp: '"A. User"' |
There was a problem hiding this comment.
Assuming you agree, I think the quotes on the samp were actually a typo in the original, because there would probably only be a tag A. User not "A. User", so I you can remove them unless you think they might not be one.
github-actions
Bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
ASalbenblatt
left a comment
ASalbenblatt
left a comment
There was a problem hiding this comment.
Looks great! Thanks!
Bilka2
left a comment
Bilka2
left a comment
There was a problem hiding this comment.
Nice work! Just one tiny change to match the previous help title, please
Co-authored-by: Bilka <Bilka2@users.noreply.github.com>
github-actions
Bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
Thank you for catching this. Fixed! |
Bilka2
left a comment
Bilka2
left a comment
There was a problem hiding this comment.
Thank you both for coding and reviewing!
This branch has not been deployed
4 participants
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7545
Purpose
Adds i18n support for 2 pages: (1) Search -> People (2) Title text on Edit Chapter
Testing Instructions
Refer ticket
Credit
Sherin (she)