Repository navigation
Conversation
anmazz
marked this pull request as ready for review
July 28, 2025 04:11
Contributor
|
We would prefer if this used ActiveRecord instead of such a large amount of handwritten SQL. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-3730
Purpose
I'm opening this as a draft so I can get feedback on my general approach/design decisions. This will hopefully have a lot of discussion if/when people can review.
Added:
Design approach
I began trying to use ActiveRecord but realized that was probably not the best way to go about this. This SQL is pretty big, but I've tried to evolve it so that it's easier to read with the CTEs and comments. That being said, it's still a lot, so sorry 😬.
My main goal was to do a union between the series and work stats and project them onto a single, standard object for ease of sorting. I felt the raw SQL was the best and most performant option for this since it gives me fine-grain control over selects/aggregates, doesn't hydrate a bunch of ActiveRecord entries, and avoids N+1 queries altogether. I've also tried as much as possible to limit Cartesian explosion.
Things to consider
There's a bunch of commented stuff/puts statements/linting errors/failed tests galore that I'll clean up later so apologies for that. Open to feedback on any and all parts of this PR!
Testing Instructions
Will fill out later.
References
Are there other relevant issues/pull requests/mailing list discussions? If not, you can remove this section.
Credit
anna (she/her)