Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
Member
Member
|
Yes, we had a problem on the foreign key catched by bugsnag, I already fixed that in the codebase. |
Member
|
I close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
Fixes #4222.
Ability::WebsiteManagergrantsCommunication::Website::Permalinkaccess with the conditioncommunication_website_id: managed_websites_ids, but the model's actual foreign key column iswebsite_id(as used a few lines above forCommunication::Website::Menu::Item). CanCanCan callspermalink.communication_website_idwhen checking the instance-level ability, which raisesNoMethodError: undefined method 'communication_website_id'for any website manager creating or updating a permalink.Added a model test creating a website manager scoped to a website and asserting they can manage a permalink on it. It needs the full Rails/Postgres test harness to run, which I could not stand up locally, but it mirrors the existing
permalink_test.rbcases.Niveau d'incidence