Skip to content

Add explicit --upload option for MariaDB benchmark results - #2

Merged
oppiet30 merged 32 commits into
mainfrom
feature/opt-in-benchmark-upload
Oct 10, 2026
Merged

oppiet30 merged 32 commits into
mainfrom
feature/opt-in-benchmark-upload

Conversation

@oppiet30

Copy link
Copy Markdown
Owner

Summary

  • Add a Boolean --upload switch; without it, training only writes the usual SQL fallback and never attempts a DB connection.
  • Add --db-host override and a local JSON configuration template for MariaDB IP/port/database and host authorization.
  • Restrict direct uploads to hosts explicitly listed in the local config; Euclid is explicitly blocked.
  • Use parameterized SQL and a transaction, check machine/dataset/model references, and identify a run consistently in SQL fallback and upload attempts.
  • Keep DB passwords out of Git; accept credentials through environment variables.
  • Add optional PyMySQL requirements and README instructions.

Example

python train.py --steps 10000 --upload --db-host 192.168.1.100

Review notes

  • The example config defaults to enabled: false; each upload-capable computer must be configured locally.
  • Verify the actual hostnames on Dell, OptiPlex 3040, Mini, and Raspberry Pi 5 before enabling uploads.
  • CI and code review should pass before merging. No live database connection has been tested from this environment.

@socket-security

socket-security Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedpymysql@​1.2.3100100100100100

View full report

@oppiet30
oppiet30 marked this pull request as ready for review October 10, 2026 02:06
@oppiet30
oppiet30 merged commit 316f4a6 into main Oct 10, 2026
7 checks passed
@oppiet30
oppiet30 deleted the feature/opt-in-benchmark-upload branch October 10, 2026 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant