Keep the drbd pool keyword in the pool section - #1126
Merged
Merged
Conversation
A keyword that names no section belongs to every section there is, which is what a keyword like comment wants. One that names a driver type as well belongs to one driver of every section, and the documentation invents that driver in each of them: max_peers, alone of the four keywords of the drbd pool, named its type and not its section, so the node and cluster references carried an arbitrator.drbd, an array.drbd, an asset.drbd and nineteen more, each advertising a configlet nothing accepts. It names the pool section now, as addr, template and vg already did, and the references carry the one pool.drbd there is. The contradiction is worth catching where it is written rather than where it is read, so the keyword stores of the node and of every object kind are checked for it. The stores of the driver manifests are not: their keywords name no section by design, the section being the driver group, which is given to them where the manifest is folded in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A keyword that names no section belongs to every section there is, which is what a keyword like comment wants. One that names a driver type as well belongs to one driver of every section, and the documentation invents that driver in each of them: max_peers, alone of the four keywords of the drbd pool, named its type and not its section, so the node and cluster references carried an arbitrator.drbd, an array.drbd, an asset.drbd and nineteen more, each advertising a configlet nothing accepts.
It names the pool section now, as addr, template and vg already did, and the references carry the one pool.drbd there is.
The contradiction is worth catching where it is written rather than where it is read, so the keyword stores of the node and of every object kind are checked for it. The stores of the driver manifests are not: their keywords name no section by design, the section being the driver group, which is given to them where the manifest is folded in.