Skip to content

[release-5.0] OCPNETUI-146: Dependency cleanup - #404

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:release-5.0from
rszwajko:cve_5_0_20261005
Oct 5, 2026
Merged

openshift-merge-bot[bot] merged 2 commits into
openshift:release-5.0from
rszwajko:cve_5_0_20261005

Conversation

@rszwajko

@rszwajko rszwajko commented Oct 5, 2026 •

Copy link
Copy Markdown

Migrate tests to Cypress v15

Dismiss toured guide banner on every login. Use pooling-based solution
matching the pattern used in networking-console-plugin.

Based on the fix for 4.19 branch #391

  1. replace copy-webpack-plugin with webpack 5's built-in output.copy
  2. bump major versions of test deps: cypress to v15 and mocha to v12
  3. remove version overrides except needed for resolving shared modules
  4. use self-reference syntax for version overrides that are linked to
    direct dependencies

CVE in js-yaml by updating to v3.15.2, v4.3.2, v5.4.2.
CVE-2026-84375:
https://redhat.atlassian.net/browse/OCPBUGS-115455
https://redhat.atlassian.net/browse/OCPBUGS-115463

Reference-Url: #391
Reference-Url: https://redhat.atlassian.net/browse/OCPBUGS-73669
Assisted-by: Cursor:claude-opus-4.6

Based on the fix for 4.19 branch openshift#391

1. replace copy-webpack-plugin with webpack 5's built-in output.copy
2. bump major versions of test deps: cypress to v15 and mocha to v12
3. remove version overrides except needed for resolving shared modules
4. use self-reference syntax for version overrides that are linked to
   direct dependencies

CVE in js-yaml by updating to v3.15.2, v4.3.2, v5.4.2.
CVE-2026-84375:
https://redhat.atlassian.net/browse/OCPBUGS-115455
https://redhat.atlassian.net/browse/OCPBUGS-115463

Reference-Url: openshift#391
Reference-Url: https://redhat.atlassian.net/browse/OCPBUGS-73669
Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Dismiss toured guide banner on every login. Use poolin-based solution
matching the pattern used in networking-console-plugin.

Assisted-by: Cursor:claude-opus-4.6
Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 5, 2026
@openshift-ci-robot

openshift-ci-robot commented Oct 5, 2026 •

Copy link
Copy Markdown

@rszwajko: This pull request references OCPNETUI-146 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Migrate tests to Cypress v15

Dismiss toured guide banner on every login. Use poolin-based solution
matching the pattern used in networking-console-plugin.

Based on the fix for 4.19 branch #391

  1. replace copy-webpack-plugin with webpack 5's built-in output.copy
  2. bump major versions of test deps: cypress to v15 and mocha to v12
  3. remove version overrides except needed for resolving shared modules
  4. use self-reference syntax for version overrides that are linked to
    direct dependencies

CVE in js-yaml by updating to v3.15.2, v4.3.2, v5.4.2.
CVE-2026-84375:
https://redhat.atlassian.net/browse/OCPBUGS-115455
https://redhat.atlassian.net/browse/OCPBUGS-115463

Reference-Url: #391
Reference-Url: https://redhat.atlassian.net/browse/OCPBUGS-73669
Assisted-by: Cursor:claude-opus-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Oct 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: f517369a-50e7-4a92-9613-f51c829409e8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

Copy link
Copy Markdown

Pipeline controller notification

This PR uses the pipeline controller for second-stage tests. Selection and triggering follow the repository configuration.

Use /test ? to list jobs, /pipeline remaining to request missing second-stage tests, or /pipeline required to rerun the selected second-stage set.

@rszwajko

rszwajko commented Oct 5, 2026

Copy link
Copy Markdown
Author

/test e2e-tests

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2026
@rszwajko
rszwajko requested review from lkladnit and removed request for adamviktora and galkremer1 October 5, 2026 14:05
@openshift-ci

openshift-ci Bot commented Oct 5, 2026

Copy link
Copy Markdown

@rszwajko: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lkladnit lkladnit left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Oct 5, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkladnit, rszwajko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 459762b into openshift:release-5.0 Oct 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants