cmake: Fix NN_SDK_VER - #84
Merged
Merged
Conversation
Member
|
This looks fine to me since these macros are needed in the header. When downstream code compile their source, they should get these macros, otherwise the header would be wrong. @german77 is that the intended effect? |
Pistonight
approved these changes
Sep 12, 2026
Author
|
Yes. Previously the observed behavior was that the sdk version was zeroed |
MonsterDruide1
approved these changes
Sep 13, 2026
MonsterDruide1
left a comment
MonsterDruide1
left a comment
Member
There was a problem hiding this comment.
@MonsterDruide1 reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on german77).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that NN_SDK_VER is not defined with the correct value in #62 because the definitions aren't propagated correctly.
My knowledge in cmake is near null but I was able to confirm that it works as it fixes all mismatches due wrong sdk version.
This change is